PaginatedByTimeAndId
#7842
PaginatedByTimeAndId
#7842
Conversation
| error.to_string(), | ||
| "unknown variant `descending`, expected `ascending`" | ||
| ); | ||
| } |
There was a problem hiding this comment.
These tests are all kinda meh to me but they run instantly and it was easy to follow the pattern of the others.
There was a problem hiding this comment.
I take it back, they caught a mistake I made.
david-crespo
force-pushed
the
pag-time-id
branch
from
119ba9c to
3df422c
Compare
There was a problem hiding this comment.
Lovely, thank you! I noticed one stale comment, but besides that, looks good to me! Perhaps @davepacheco or someone else will also want to review, since this is dropshot related, but I think it seems pretty uncontroversial.
david-crespo
force-pushed
the
pag-time-id
branch
from
3df422c to
8481a67
Compare
|
The buildomat failures don't look like actual test failures, I think something just got cancelled: https://buildomat.eng.oxide.computer/wg/0/details/01JPT598J4PT2MQZK7WA9C3PY9/BxgIch0lAi33zswBET6w88lsqbcYvrtHvBGGUkzfZznj6Y4T/01JPT59SZ3Y8G7741P4BBSJNDD#S4692 |
|
I manually cancel the old jobs when I force push so they don't take up queue space for no reason. |
david-crespo
force-pushed
the
pag-time-id
branch
from
8481a67 to
849fe23
Compare
Extracted from #7339 for use in #7277. This PR does not use the pagination helper in any endpoints. There are proper integration tests like
test_audit_log_listin #7339 demonstrating the ordering and cursor work as expected.