Skip to content

[reconfigurator] Replace todo!s with error returns #7552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2025
Merged

[reconfigurator] Replace todo!s with error returns #7552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions nexus/reconfigurator/planning/src/blueprint_builder/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -925,13 +925,23 @@ impl<'a> BlueprintBuilder<'a> {
match zone.disposition {
BlueprintZoneDisposition::Expunged => (),
BlueprintZoneDisposition::InService
| BlueprintZoneDisposition::Quiesced => todo!("fixme-1"),
| BlueprintZoneDisposition::Quiesced => {
return Err(Error::Planner(anyhow!(
"expunged all disks but a zone \
is still in service: {zone:?}"
)));
}
}
}
for dataset in editor.datasets(BlueprintDatasetFilter::All) {
match dataset.disposition {
BlueprintDatasetDisposition::Expunged => (),
BlueprintDatasetDisposition::InService => todo!("fixme-2"),
BlueprintDatasetDisposition::InService => {
return Err(Error::Planner(anyhow!(
"expunged all disks but a dataset \
is still in service: {dataset:?}"
)));
}
}
}

Expand Down
Loading