[reconfigurator] Remove spicy blueprint -> sled-agent From impls #7505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smklein
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is followup from #7308 and #7500 (comment):
From<BlueprintZonesConfig> for OmicronZonesConfig. This included expunged zones, but thankfully had no callers.BlueprintZonesConfig::to_omicron_zones_config(filter)toBlueprintZonesConfig::into_running_omicron_zones_config()(nofilterargument). All the callers of this method were passingBlueprintZoneFilter::ShouldBeRunning, and I don't think there's a reason to use any other filter?From<BlueprintPhysicalDisksConfig> for OmicronPhysicalDisksConfig(which included expunged disks), and replace it withBlueprintPhysicalDisksConfig::into_in_service_disks(). This one did have callers, including the blueprint executor, but I think we've avoided problems because the planner current drops disks if the incoming planning input says they're not in service. I'm not sure that planner behavior is right, and might change with Expunge and Decommission disks in planner #7286, so it seemed safer to go ahead and fix this now.