Add a new ClickhouseServer Omicron Zone
#6297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new zone type reflects the zone with which we'll deploy clickhouse server nodes in a replicated setup. We decided on using a new zone type rather than adding a boolean field to the existing `Clickhouse` zone type that is used for single server deployments in last Tuesday's (Aug 6, 2024) update huddle. This is the fist part of the work to be done for replicated clickhouse deployments that are automated via reconfigurator. As such, the actual zone deployment is left as a `todo`.
sunshowers
reviewed
Aug 13, 2024
| ZoneKind::BoundaryNtp | ZoneKind::InternalNtp => Self::NTP_PREFIX, | ||
| ZoneKind::Clickhouse => "clickhouse", | ||
| ZoneKind::ClickhouseKeeper => "clickhouse-keeper", | ||
| ZoneKind::ClickhouseServer => "clickhouse_server", |
Contributor
There was a problem hiding this comment.
oh... this isn't going to work, needs a dash. (Should add a test for this!)
sunshowers
added a commit
that referenced
this pull request
Aug 13, 2024
) Followup from #6297 -- `name_prefix` requires dashes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new zone type reflects the zone with which we'll deploy clickhouse server nodes in a replicated setup. We decided on using a new zone type rather than adding a boolean field to the existing
Clickhousezone type that is used for single server deployments in last Tuesday's (Aug 6, 2024) update huddle.This is the fist part of the work to be done for replicated clickhouse deployments that are automated via reconfigurator. As such, the actual zone deployment is left as a
todo.