[nexus] Manage datasets via reconfigurator #6229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgallagher
reviewed
Sep 26, 2024
smklein
added a commit
that referenced
this pull request
Oct 1, 2024
Building off of: - #6229 (comment) - #6694 - https://github.com/oxidecomputer/sqldance This PR acknowledges that `SELECT FOR UPDATE` is a performance "optimization" in the situation where a blueprint's value is checked before performing a subsequent operation, as we do with setting network resources. It arguably could make performance worse in certain cases, as it locks out concurrent read operations from accessing the database. This PR removes the usage of `SELECT FOR UPDATE`, and significantly overhauls the `test_ensure_external_networking_bails_on_bad_target` test to account for the concurrent control that CockroachDB may be performing with respect to operation re-ordering. --------- Co-authored-by: John Gallagher <[email protected]>
hawkw
pushed a commit
that referenced
this pull request
Oct 2, 2024
Building off of: - #6229 (comment) - #6694 - https://github.com/oxidecomputer/sqldance This PR acknowledges that `SELECT FOR UPDATE` is a performance "optimization" in the situation where a blueprint's value is checked before performing a subsequent operation, as we do with setting network resources. It arguably could make performance worse in certain cases, as it locks out concurrent read operations from accessing the database. This PR removes the usage of `SELECT FOR UPDATE`, and significantly overhauls the `test_ensure_external_networking_bails_on_bad_target` test to account for the concurrent control that CockroachDB may be performing with respect to operation re-ordering. --------- Co-authored-by: John Gallagher <[email protected]>
Collaborator
Author
|
Rebased and passing all tests - happy to take another pass here with folks as that would be useful. |
jgallagher
approved these changes
Oct 30, 2024
This was referenced Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the blueprint aware of datasets, and manages them as a part of planning and execution.
As a part of the planning phase: the reconfigurator ensures that all in-service disks have debug / zone root datasets, and that all zones have the corresponding datasets they need to function. Additionally, unused datasets are marked as "expunged" until they are gone from the database, at which point they're fully deleted from the blueprint.
As a part of the execution phase: the reconfigurator ensures that database records exist for these datasets, and requests them from appropriate sled agents. Additionally, "expunged" datasets are removed from the database explicitly.
Fixes #6043
Fixes #6107