Skip to content

Datastore: add a thorough test of deleting inventory collections #5305

@jgallagher

Description

@jgallagher

When adding new data to inventory collections, it is easy to forget to update DataStore::inventory_delete_collection() to remove that new data, which leads to unbounded and quick growth of the new data (e.g., #5299). @smklein and @davepacheco at various times have both proposed a test roughly structured like:

  1. Create a snapshot of the database state (critically, this needs to include "potentially new tables that have been added since this test was written")
  2. Insert a collection
  3. Delete that collection
  4. Confirm that the database matches the snapshot taken in 1

Metadata

Metadata

Assignees

No one assigned

    Labels

    databaseRelated to database accessdevelopmentBugs, paper cuts, feature requests, or other thoughts on making omicron development better

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions