Handle fleet viewers without permission to see SCIM tokens #2957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
david-crespo
commented
Oct 30, 2025
| <TokenCreatedModal token={token} onDismiss={() => setModalState(false)} /> | ||
| )) | ||
| .with(false, () => null) | ||
| .exhaustive()} |
Collaborator
Author
There was a problem hiding this comment.
addicted to ts-pattern
david-crespo
commented
Oct 30, 2025
| .then((data) => ({ type: 'success' as const, data })) | ||
| .catch((data) => ({ type: 'error' as const, data })), | ||
| .then((data: Result<A[M]>) => ({ type: 'success' as const, data })) | ||
| .catch((data: ApiError) => ({ type: 'error' as const, data })), |
Collaborator
Author
There was a problem hiding this comment.
This was a bug in apiqErrorsAllowed causing the data field to have type any in both arms. There is a better way to do this without casting but I'm going to do it later.
david-crespo
commented
Oct 30, 2025
| type ModalState = | ||
| | { kind: 'create' } | ||
| | { kind: 'created'; token: ScimClientBearerTokenValue } | ||
| | false |
Collaborator
Author
There was a problem hiding this comment.
this makes it impossible to accidentally have both modals rendered at once
david-crespo
commented
Oct 30, 2025
| } | ||
|
|
||
| function TokensTable({ tokens }: { tokens: ScimClientBearerToken[] }) { | ||
| const siloSelector = useSiloSelector() |
Collaborator
Author
There was a problem hiding this comment.
Moved the table logic to its own component that only renders on success responses so we don't have to pollute with if-else checks.
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 31, 2025
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ended up doing quite a bit of shuffling around, but the main thing is switching to
apiqErrorsAllowedand displaying a different thing when it comes back as an error.Jane Austen is a fleet viewer but not a fleet or silo admin: