Refetch button on instances page #1295
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| // meant for buttons that only contain a single icon | ||
| icon: 'h-8 w-8 text-mono-sm svg:w-4', | ||
| base: 'h-10 px-3 text-mono-md svg:w-5', | ||
| } |
There was a problem hiding this comment.
Was going to make icon? a separate boolean prop, but unless it put on all the relevant size styles, it would rely on the caller also passing size="sm", which is stupid. And if it does put all the relevant size styles, it's a size. So I made it a size.
| | 'type' | ||
| | 'title' | ||
| | 'form' | ||
| > & |
There was a problem hiding this comment.
This is not at all necessary, and maybe this is a me thing, but 256 more drives me crazy. I feel like I'm staring into the abyss.
There was a problem hiding this comment.
I suppose it's fine. It's a code change to address tooltip content though which seems to be a bit of a smell, but I agree the tooltip isn't incredibly helpful.
We should probably change these to interfaces anyway. Doing so it basically just won't show anything in the tooltip anyway, ha. That doesn't make the tooltip experience any better, but maybe it would assuage the aesthetic concern of the ... 256 more ... message without the prop restriction.
There was a problem hiding this comment.
It's not just the tooltip content, it's also the real possibility that there could be buttons out there with any of those props. I like being able to rule that out.
|
@zephraph and I noticed our button color and variant implementation is now out of step with the design. I will follow up with a PR to fix that. |
Closes #1178. This gets rid of the only remaining instance of polling outside of the sliding metrics windows.
<Button>now takes a narrowed-down selection of props from<button>instead of all of them