Enable disabled reason tooltip on button #1293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
just-be-dev
commented
Nov 9, 2022
| variant="default" | ||
| size="sm" | ||
| onClick={() => setShowDiskCreate(true)} | ||
| disabledReason="Instance must be stopped to create a disk" |
Contributor
Author
There was a problem hiding this comment.
This is an example and might not hang around.
just-be-dev
commented
Nov 9, 2022
just-be-dev
commented
Nov 9, 2022
libs/ui/lib/button/Button.tsx
Outdated
Comment on lines
126
to
128
| <Wrap | ||
| when={disabled && disabledReason} | ||
| with={<Tooltip content={disabledReason!} childAsAnchor />} |
Contributor
Author
There was a problem hiding this comment.
Initially I just was using the hooks API here but the problem with that is that it always executes the tooltip calculation logic which is unnecessary. You can't put a hook behind conditional logic so I converted it over to the component interface so that it could be conditionally included.
just-be-dev
commented
Nov 9, 2022
| </Component> | ||
| {tip && ( | ||
| <Tooltip id={`${id}-tip`} content={tip}> | ||
| <Tooltip content={tip}> |
Contributor
Author
There was a problem hiding this comment.
id was unnecessary
just-be-dev
commented
Nov 9, 2022
david-crespo
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lays the groundwork to resolve #1029. It builds off of #854 and #1292 to allow buttons to have a tooltip that describes why it's disabled. This is forming up to be a fundamental product principle: Don't show the user a disabled action without describing why it's disabled. Further (and a bit of an aside) if there's something the user can do to make it not be disabled then we shouldn't have it disabled at all. We should guide them through the experience of doing whatever they're trying to do.