[fix/close-preview-on-delete] "Close" viewer when viewed item is being deleted #1495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix formatting and update code style in OCItem.didSet - add .itemRemovedView and .hasBeenRemoved properties to manage showing an "Item removed" message when the item was removed while being viewed - handle .targetHasBeenRemoved item query state and trigger: - displaying an "Item removed" message by setting .hasBeenRemoved - if its the only item and the browser history has more items to show: remove the display view controller and its host from history, effectively going back to the previous view controller
hosy
approved these changes
Sep 9, 2025
|
Approved on my side 👍 |
jesmrec
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If an item is being deleted while being viewed, the viewer shows a "Item removed" message and - if it is the only file being viewed and the viewer is not the only item in the browser history - "closes" the viewer by removing it from history.
Related Issue
#1484
Screenshots (if appropriate):
Types of changes