Replace deprecated NamedArgumentConstructorAnnotation with @NamedArgumentConstructor + Address one PHP 8.1 deprecation
#941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should be replaced with `@NamedArgumentConstructor`.
In PHP 8.1 optional parameters cannot be defined before required parameters. Because `string name = null` is optional, we also have to make `string $resolveType`optional. This way it works on PHP 8.1 without breaking BC. In 1.0, we should change the order.
|
@mcg-web Please have a look. If you merge this, please also update master so that I can immediately address the deprecation there. |
Merged
mcg-web
approved these changes
Dec 6, 2021
|
done @ruudk ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed a problem that will pop-up in PHP 8.1 with the
TypeInterface:In PHP 8.1 optional parameters cannot be defined before required parameters.
Because
string name = nullis optional, we also have to makestring $resolveTypeoptional. This way it works on PHP 8.1 without breaking BC.In 1.0, we should change the order.