Improve GraphQLServices by making it a ServiceLocator #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcg-web
force-pushed
the
improve-graphql-services
branch
4 times, most recently
from
92e01d5 to
c9e6c1f
Compare
mcg-web
force-pushed
the
improve-graphql-services
branch
from
c9e6c1f to
a51dc91
Compare
murtukov
reviewed
Apr 30, 2021
murtukov
approved these changes
Apr 30, 2021
|
@mcg-web there are a couple of changes I would like to address, but I will open a separate PR for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allow
GraphQLServicesto load services only on demand.