Skip to content

Fix annotations #739 #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix annotations #739 #740

wants to merge 1 commit into from

Conversation

Vincz
Copy link
Collaborator

@Vincz Vincz commented Aug 17, 2020

Q A
Bug fix? yes
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets #739
License MIT

Fix the bad @required on annotations

@Vincz Vincz requested review from mcg-web and murtukov August 17, 2020 08:14
@mcg-web
Copy link
Contributor

mcg-web commented Aug 17, 2020

This fix should be done from 0.12.

@Vincz Vincz mentioned this pull request Aug 17, 2020
Merged
@Vincz
Copy link
Collaborator Author

Vincz commented Aug 17, 2020

Done in #741

@mcg-web mcg-web closed this Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcg-web mcg-web Awaiting requested review from mcg-web

1 more reviewer

@murtukov murtukov murtukov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vincz @mcg-web @murtukov