Make the docker image more usable #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bartv2
commented
Aug 16, 2020
bartv2
commented
| Q | A |
|---|---|
| Bug fix? | yes/no |
| New feature? | yes/no |
| BC breaks? | yes/no |
| Deprecations? | yes/no |
| Tests pass? | yes/no |
| Documented? | yes/no |
| Fixed tickets | #... |
| License | MIT |
|
composer 2 also supports parallel fetching of the dependencies, maybe it’ll be easier for maintenance to just wait for a stable release of composer (or include the alpha version) |
mcg-web
reviewed
Aug 16, 2020
| @@ -5,6 +5,6 @@ | |||
| !/benchmarks/ | |||
| !/composer.json | |||
| !/phpunit.xml.* | |||
| !/phpstan.neon.* | |||
| !/phpstan*.neon | |||
There was a problem hiding this comment.
@mcg-web I think because i renamed the phpstan.neon.dist long time ago
There was a problem hiding this comment.
Yes the name changed and the config wasn't included
| @@ -7,7 +7,7 @@ FROM scratch AS test_source | |||
| COPY benchmarks/ benchmarks/ | |||
| COPY src/ /src/ | |||
| COPY tests/ /tests/ | |||
| COPY phpunit.xml.* phpstan.neon.* .php_cs.* phpbench.json / | |||
| COPY phpunit.xml.* phpstan*.neon .php_cs.* phpbench.json / | |||
|
composer install is slow, doing parallel downloads helps a lot. This was the solution that i also use in other projects. |
mcg-web
approved these changes
Aug 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.