Allow cleaner access syntax in expressions #709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcg-web
reviewed
Jul 10, 2020
|
Can you also add an update note please? |
|
What update note? Where? |
|
In UPGRADE-1.0.md to describe the change done to public interface. |
|
@mcg-web done |
Update UPGRADE-1.0.md
murtukov
force-pushed
the
feature/args-clean-syntax
branch
from
21c113f to
87ca419
Compare
mcg-web
approved these changes
Jul 11, 2020
|
Thank you @murtukov ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a magic
__getmethod to theArgumentclass, to allow a cleaner syntax in the expressions.Instead of this:
@=res('my_resolver', [args['firstName'], args['lastName']])We can write this:
@=res('my_resolver', [args.firstName, args.lastName])which is obviously easier to read and is shorter.
And inside resolvers user can do
$args->firstName,$args->lastName