Changes setup of expression language functions to fix issue #588 #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murtukov
approved these changes
Jul 8, 2020
|
LGTM too. I've made couple of changes in the master tho, so that |
|
Thanks you @sgehrig for fixing this annoying issue 👍🏻 |
Any chance to do a new release for 0.13.3? Oh, and thanks for merging the PR so quick. |
|
done @sgehrig ! Thanks again for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in comment #588 (comment) the true problem behind issue #588 is that the setup of the expression language functions is flawed. The expression language functions are not designed to take services as constructor arguments. Instead they must rely on dependencies passed into the function during execution.
This PR fixes these issues with several expression language functions. Instead of passing dependencies to the constructor (from where they were injected into closures), the evaluators no rely on the
'globalVariable'in the$argumentsparameter - just as the compiler relies on$globalVariablevariable in the execution context.'globalVariable'just points to an instance ofOverblog\GraphQLBundle\Definition\GlobalVariables(again just the same as for complied function execution).Because all of the expression language functions are auto-wired and because the evaluator is only used directly in
Overblog\GraphQLBundle\Validator\Constraints\ExpressionValidator, there has only been a slight service configuration change (the servicevalidator.expression(instance ofOverblog\GraphQLBundle\Validator\Constraints\ExpressionValidator) now also requires theOverblog\GraphQLBundle\Definition\GlobalVariablesservice as its second constructor argument.