Skip to content

Update return typehint for SchemaBuilder #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 24, 2019
Merged

Update return typehint for SchemaBuilder #630

merged 1 commit into from
Dec 24, 2019

Conversation

kix
Copy link
Contributor

@kix kix commented Dec 24, 2019

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documented? nothing to document
Fixed tickets none
License MIT

Previously, running bin/console lint:container with this bundle installed lead to this error output:

  Invalid definition for service "overblog_graphql.request_executor": argument 2 of "Overblog\GraphQLBundle\Request\Executor::addSchemaBuilder" accepts "callable", "Closure" passed.

This fixes this error by passing \Closure from \Overblog\GraphQLBundle\Definition\Builder\SchemaBuilder::getBuilder to Executor::addSchemaBuilder.

@mcg-web
Copy link
Contributor

mcg-web commented Dec 24, 2019

Thank you @kix !

@mcg-web mcg-web merged commit 05eb609 into overblog:master Dec 24, 2019
@kix kix deleted the schema-builder-typehint branch December 24, 2019 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants