Update YamlParser.php #304
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More comfortable to use constant in some configs. Especially in enum type
|
@AlexGural thanks for you contribution! Thank you again |
|
@renatomefi sure no problem. I`m going to do this soon |
|
Corresponding issue: #303. |
|
@AlexGural ping, are you still willing to do this? Thanks again! |
|
@renatomefi I added a small test. I was confused a little bit because I didn`t find tests for YamlParser and symfony parser has a good coverage. |
|
Any updates on this?👀 |
|
Closing this because of inactivity, feel free to continue discussion if this is still needed |
murtukov
pushed a commit
to murtukov/graphql-bundle
that referenced
this pull request
Aug 10, 2020
- Add the `Yaml::PARSE_CONSTANT` flag to the YamlParser to allow `!php/const` tags - Add test for parsing yaml files with constants - Adjust documentation for enums Fix issue overblog#303. Based on pull request overblog#304
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More comfortable to use constant in some configs. Especially in enum type
Add possibility to use native constant expression for
.yml