fix http tests on node 8 #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayes
force-pushed
the
hayes/fix-http-tests
branch
2 times, most recently
from
03f12c7 to
61113e7
Compare
|
As far as I know there's nothing wrong with the tests in Node 7 (except for the thing that's actually a bug in Node it self). Which things failed in Node 7? |
|
You are correct, I initially had.added an exception for that but in this PR before I really understood the issue, I should update the commit message and PR description |
|
Cool 👍 And thanks for taking the time to fix this 👊 I guess this then takes care of my concern in #115 (comment) if we can merge it soon |
|
Dug in a little more, and I am pretty confident everything is working correctly on node 8, so this should be good to merge. |
hayes
force-pushed
the
hayes/fix-http-tests
branch
from
61113e7 to
67ce620
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests have not been passing on node 8. This should get them passing again, but I I did not properly dig into whether or not changing the tests is the right thing, or if there is something that was broken in the instrumentation.
I suspect that changing the tests is safe here, but further investigation is probably required to ensure nothing was actually broken.