Skip to content

Conversation

@osrecio
Copy link
Owner

@osrecio osrecio commented May 29, 2018

Original Pull Request

magento#15269

Description

Fixes a typo in the \Magento\Framework\Image::open exception message.

Previous message:

File {file} does not exists.

Corrected message:

File {file} does not exist.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

  1. Given that...
  • There exists a page where an image is opened,
  • but the actual image file does not exist,
  • and the exception is not silently caught and ignored,
  1. Expect to receive a properly-spelled exception message.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@osrecio osrecio force-pushed the 2.3-develop-PR-port-15269 branch from a203e23 to 154fc40 Compare May 29, 2018 15:34
@osrecio osrecio closed this May 29, 2018
osrecio pushed a commit that referenced this pull request Jul 19, 2018
[Forwardport] Fixed set template syntax issue
osrecio pushed a commit that referenced this pull request Aug 20, 2018
[Forwardport] Remove unnecessary translation of HTML tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants