Preventing empty array declarations during code generation. #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vineetbansal
approved these changes
Feb 14, 2022
There was a problem hiding this comment.
Thanks @maxschaller - looks good. We're currently not testing the case when P is None. I'll add that as a TODO on my end (and incorporate codegen testing in our CI so we can catch these errors faster..)
vineetbansal
pushed a commit
that referenced
this pull request
Feb 14, 2022
Open
lb3825
pushed a commit
to lb3825/osqp-python
that referenced
this pull request
Aug 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of linear programs, the
cscmatrixPis empty. Previously, amongst others, empty (zero length) index and data arrays forPwere generated. Some compilers will throw an error because of this. This pull request prevents the declaration of empty arrays and specifiesNULLpointers where needed.