Skip to content

Conversation

oschulz
Copy link
Owner

@oschulz oschulz commented Jun 27, 2023

Changes with_jacobian to take operator type argument, so users should now do

with_jacobian(f, x, LinearMap, ad)
with_jacobian(f, x, MatrixLikeOperator, ad)
with_jacobian(f, x, Matrix, ad)

MatrixLikeOperator can be deprecated and removed in future releases since LinearMaps has a pretty low load time now.

CC @dkarrasch

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage: 48.48% and project coverage change: -3.16 ⚠️

Comparison is base (4c9e206) 79.15% compared to head (797062b) 76.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
- Coverage   79.15%   76.00%   -3.16%     
==========================================
  Files           9       10       +1     
  Lines         355      375      +20     
==========================================
+ Hits          281      285       +4     
- Misses         74       90      +16     
Impacted Files Coverage Δ
src/AutoDiffOperators.jl 100.00% <ø> (ø)
src/ad_selector.jl 47.61% <ø> (ø)
src/mulfunc_operator.jl 0.00% <0.00%> (ø)
ext/AutoDiffOperatorsEnzymeExt.jl 100.00% <100.00%> (ø)
ext/AutoDiffOperatorsForwardDiffExt.jl 74.28% <100.00%> (+0.75%) ⬆️
ext/AutoDiffOperatorsLinearMapsExt.jl 76.92% <100.00%> (+4.19%) ⬆️
ext/AutoDiffOperatorsZygoteExt.jl 84.61% <100.00%> (ø)
src/jacobian.jl 82.75% <100.00%> (+0.40%) ⬆️
src/matrix_like_operator.jl 79.76% <100.00%> (+0.23%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oschulz oschulz merged commit 797062b into main Jun 27, 2023
@oschulz oschulz deleted the operator-types branch June 27, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant