BRND template #193
Open
BRND template #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnetemoos
force-pushed
the
feature/brnd
branch
from
7757c44 to
afb376d
Compare
tuj
requested changes
Oct 24, 2025
| { | ||
| "title": "BRND sportcenter dagsprogram", | ||
| "icon": "", | ||
| "id": "01FRJPF4XATRN8PBZ35XN84PS6", |
There was a problem hiding this comment.
Important! The id of a new template should be a new ULID. This is the same as calendar template:
https://github.com/os2display/display-templates/blob/develop/src/calendar/calendar-config.json#L4
You can generate a new ULID with the following command (in API):
https://github.com/os2display/display-api-service/blob/develop/src/Command/GenerateUlid.php#L15
| </ContentItemsWrapper> | ||
| <ContentItemsWrapper className="schedule-rows"> | ||
| {bookings?.length > 0 && | ||
| getSortedBookings(bookings).map((entry) => { |
There was a problem hiding this comment.
Why bind returnFragment to a variable and return it afterwards?
Suggested change
| getSortedBookings(bookings).map((entry) => { | |
| getSortedBookings(bookings).map((entry) => ( | |
| <Fragment> | |
| </Fragment> | |
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
Fixes os2display/display-api-service#309
Description
Template to show all todays BRND bookings for a sports center