Skip to content
This repository was archived by the owner on May 28, 2021. It is now read-only.

Fix CRD and RBAC issues when installing 0.1.x via helm #142

Merged
merged 6 commits into from
Jun 15, 2018
Merged

Fix CRD and RBAC issues when installing 0.1.x via helm #142

merged 6 commits into from
Jun 15, 2018

Conversation

prydie
Copy link

@prydie prydie commented Jun 14, 2018

Resolves: #135

@prydie prydie added the bug label Jun 14, 2018
@prydie prydie requested a review from owainlewis June 14, 2018 16:33
@owainlewis
Copy link
Member

owainlewis commented Jun 15, 2018 •
edited
Loading

This currently fails because we end up doing a semver compare on a non semvar tag in tests.

--set image.tag=82ce736a80f2cf344183e7449945014997b07136

We could do something less elegant like hasPrefix see https://godoc.org/github.com/Masterminds/sprig

@owainlewis owainlewis merged commit 4c54192 into master Jun 15, 2018
@owainlewis owainlewis deleted the ap/fix-135 branch June 15, 2018 10:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@owainlewis owainlewis owainlewis approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prydie @owainlewis