generated from oracle/template-repo
-
Couldn't load subscription status.
- Fork 30
refactor: use problog for suspicious combinations #997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Parent:
chore: merge changes to main
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Poll! What is the preferred way to represent each logical rule over multiple lines: or 2. |
113a596 to
be5148b
Compare
…l statements Signed-off-by: Carl Flottmann <[email protected]>
Signed-off-by: Carl Flottmann <[email protected]>
…ing the CI fail. Signed-off-by: Carl Flottmann <[email protected]>
Signed-off-by: Carl Flottmann <[email protected]>
11187ad to
72e2608
Compare
Signed-off-by: Carl Flottmann <[email protected]>
behnazh-w
reviewed
Mar 12, 2025
src/macaron/slsa_analyzer/checks/detect_malicious_metadata_check.py
Outdated
Show resolved
Hide resolved
src/macaron/slsa_analyzer/checks/detect_malicious_metadata_check.py
Outdated
Show resolved
Hide resolved
src/macaron/slsa_analyzer/checks/detect_malicious_metadata_check.py
Outdated
Show resolved
Hide resolved
…ity, with better comments Signed-off-by: Carl Flottmann <[email protected]>
behnazh-w
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the
SUSPICIOUS_COMBOSdictionary to instead use aproblogmodel. The purpose of this is to simplify the dictionary into logical statements, and allow for future development of probabilistic rules. This model transforms theHeuristicResulttypes as follows:HeuristicResult.FAILresults in<name> :- false.HeuristicResult.PASSresults in<name> :- true.HeuristicResult.SKIPresults in0.0::<name>, which means any rules which require this heuristic do not trigger.To do:
Current issues with including
problogthat need to be resolved:probloghas no typing stubs. Currently it's just been ignored inpyproject.toml.detect_malicious_metadata_check.pyproblogcurrently causes the following warnings on tests: