feat: add callgraph and build cmd detection for Jenkins #977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
behnazh-w
force-pushed
the
behnazh/improve-build-cmd-detection
branch
2 times, most recently
from
dbe2525 to
1bd3563
Compare
tromai
reviewed
Mar 14, 2025
tromai
reviewed
Mar 14, 2025
tromai
reviewed
Mar 17, 2025
tromai
reviewed
Mar 17, 2025
tromai
reviewed
Mar 17, 2025
Signed-off-by: behnazh-w <[email protected]>
Signed-off-by: behnazh-w <[email protected]>
behnazh-w
force-pushed
the
behnazh/improve-build-cmd-detection
branch
from
1bd3563 to
21c36d0
Compare
tromai
approved these changes
Mar 18, 2025
Signed-off-by: behnazh-w <[email protected]>
tromai
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR introduces the construction of callgraphs for bash scripts inlined within
Jenkinsfileconfigurations. Additionally, it createsBuildToolCommandobjects, which will be utilized in the build-related checks. With this update, Jenkins is no longer categorized as an unparsed CI service, although parsing support remains partial.Tests:
pkg:maven/org.apache.dubbo/[email protected]artifact, which uses Jenkins for builds.tests/integration/cases/jenkinsci_plotpluginhas been updated to reflect the absence of a build service command.TODO:
Similar to GitHub Actions, we aim to support recursive calls to bash scripts within
Jenkinsfile. The implementation should be straightforward, but it is recommended to first refactor thebashparserto decouple it from GitHub Actions, making it more general: #978