feat: allow provenance files to be files containing a URL pointing to… #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the actual provenance file which will be transparently downloaded URL link file format is the Windows .url file format i.e. an ini file containing a "URL" field inside an "InternetShortcut" section. When processing the URL link provenance file, the content will be transparently downloaded if the hostname of the URL is configured as an allowed hostname in the defaults.ini file. Signed-off-by: Nicholas Allen <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
behnazh-w
reviewed
Apr 18, 2024
| try: | ||
| # TODO download size limit? | ||
| timeout = defaults.getint("downloads", "timeout", fallback=120) | ||
| response = requests.get(url=url, timeout=timeout) |
Member
There was a problem hiding this comment.
We should use the send_get_http_raw helper function so that we can improve the implementation in one place as explained in this issue.
nathanwn
reviewed
Apr 18, 2024
nathanwn
reviewed
Apr 18, 2024
…l file content, and simplify file-content decoding Signed-off-by: Nicholas Allen <[email protected]>
tromai
reviewed
Apr 19, 2024
tromai
reviewed
Apr 19, 2024
tromai
suggested changes
Apr 19, 2024
Contributor
tromai
left a comment
tromai
left a comment
There was a problem hiding this comment.
Thanks for the changes. I have left some comments. Other than those, everything else looks good to me.
Signed-off-by: Nicholas Allen <[email protected]>
art1f1c3R
pushed a commit
that referenced
this pull request
Nov 29, 2024
… the actual provenance file which will be transparently downloaded (#710) URL link file format is the Windows .url file format i.e. an ini file containing a "URL" field inside an "InternetShortcut" section. When processing the URL link provenance file, the content will be transparently downloaded if the hostname of the URL is configured as an allowed hostname in the defaults.ini file. Signed-off-by: Nicholas Allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the actual provenance file which will be transparently downloaded
URL link file format is the Windows .url file format i.e. an ini file containing a "URL" field inside an "InternetShortcut" section. When processing the URL link provenance file, the content will be transparently downloaded if the hostname of the URL is configured as an allowed hostname in the defaults.ini file.