refactor!: allow the branch name in the schema of a repository to be null #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behnazh-w
added
repository_finder
behnazh-w
added this to the
Change the data model to allow analysis at artifact level milestone
oracle-contributor-agreement
bot
added
the
OCA Verified
…null Signed-off-by: behnazh-w <[email protected]>
behnazh-w
force-pushed
the
update-type-branch-repo
branch
from
3394851 to
75f8ced
Compare
benmss
approved these changes
Oct 30, 2023
tromai
previously approved these changes
Oct 30, 2023
tromai
dismissed
their stale review
I mistakenly click the approve button. It was not supposed to be an approval.
tromai
approved these changes
Oct 31, 2023
art1f1c3R
pushed a commit
that referenced
this pull request
Nov 29, 2024
…null (#532) This PR changes the Repository schema in the data model to allow a branch name to be None. This is in preparation for mapping artifacts to commits because sometimes we might not be able to find a branch. However, we should still be able to checkout using the resolved commit hash. Note that the local `macaron.db` needs to be removed to apply this change in the data model, hence the breaking change scope in the PR title. Signed-off-by: behnazh-w <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
Repositoryschema in the data model to allow a branch name to beNone. This is in preparation for mapping artifacts to commits because sometimes we might not be able to find a branch. However, we should still be able to checkout using the resolved commit hash.Note that the local
macaron.dbneeds to be removed to apply this change in the data model, hence the breaking change scope in the PR title.