Skip to content

Conversation

benmss
Copy link
Member

@benmss benmss commented Jun 25, 2025

Summary

This PR updates the npm provenance discovery tutorial to include the newer discovery methods: PyPI and GitHub.

Description of changes

  • The tutorial is updated to provide examples of provenance discovery for PyPI and GitHub using the toga PyPI library, which has provenance of either type available for discovery depending on the exact version specified.
  • For GitHub attestation, a small code update is included to allow the repository URL and commit digest to be found from provenance.
  • The npm part of the tutorial is updated to use a newer version of the semver library 7.7.2

Removal of verify-provenance and Download Changes

As part of this PR, the verify-provenance command line argument has been removed, making this action occur by default once again. This command was originally introduced due to concerns about downloading overly large files, thereby slowing down analyses. Instead of this, a file size limit has been imposed for download operations that were previously using the Stream functionality.
In cases where the size is not known before the download begins (most cases), the download will terminate when the streamed data exceeds the limit. This limit can be configured in the defaults.ini and defaults to 10mb. This is not sufficient for two of our existing integration tests and they have been adjusted accordingly.

@benmss benmss self-assigned this Jun 25, 2025
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 25, 2025
@benmss benmss marked this pull request as ready for review June 26, 2025 00:02
@benmss benmss requested review from behnazh-w and tromai as code owners June 26, 2025 00:02
Copy link
Member

@behnazh-w behnazh-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add integration tests for the toga package with a tutorial label. We make sure to have an integration test for all of our tutorials and catch changes/issues.

@behnazh-w behnazh-w added this to the Release version 0.17.0 milestone Jul 21, 2025
@benmss benmss force-pushed the benmss/update-provenance-tutorial branch 2 times, most recently from b98767a to cf97722 Compare July 29, 2025 04:43
@behnazh-w behnazh-w requested a review from Demolus13 August 18, 2025 03:03
benmss added 9 commits August 25, 2025 14:46
…test as tutorial; update tutorial wording; include tutorial sections for CI and local provenance; add input attestation predicate and build types

Signed-off-by: Ben Selwyn-Smith <[email protected]>
…rify-provenance option

Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
@benmss benmss force-pushed the benmss/update-provenance-tutorial branch from a35083e to a061e56 Compare August 25, 2025 04:47
@behnazh-w behnazh-w merged commit 92e9032 into main Aug 25, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provenance verification should be enabled by default with a restricted download size
3 participants