Skip to content

Conversation

@benmss
Copy link
Member

@benmss benmss commented Mar 31, 2025

This cleans up some redundant lines in the souffle install script for Ubuntu

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 31, 2025
@benmss benmss force-pushed the benmss/update-ubuntu-build-fix branch from f6e998b to d126de1 Compare March 31, 2025 04:10
@benmss benmss self-assigned this Mar 31, 2025
Signed-off-by: Ben Selwyn-Smith <[email protected]>
benmss added 2 commits April 1, 2025 10:03
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
@benmss benmss force-pushed the benmss/update-ubuntu-build-fix branch from c996aa7 to 693e24f Compare April 1, 2025 04:18
@benmss benmss marked this pull request as ready for review April 1, 2025 04:28
Copy link
Contributor

@tromai tromai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than https://github.com/oracle/macaron/pull/1034/files#r2022177594. Everything else looks good to me. Thanks

Signed-off-by: Ben Selwyn-Smith <[email protected]>
Copy link
Contributor

@tromai tromai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@benmss benmss merged commit 6f54975 into staging Apr 2, 2025
10 checks passed
@benmss benmss deleted the benmss/update-ubuntu-build-fix branch April 2, 2025 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants