Skip to content

Commit 7eef451

Browse files
matttbejfvogel
authored andcommitted
selftests: mptcp: join: validate C-flag + def limit
commit 008385efd05e04d8dff299382df2e8be0f91d8a0 upstream. The previous commit adds an exception for the C-flag case. The 'mptcp_join.sh' selftest is extended to validate this case. In this subtest, there is a typical CDN deployment with a client where MPTCP endpoints have been 'automatically' configured: - the server set net.mptcp.allow_join_initial_addr_port=0 - the client has multiple 'subflow' endpoints, and the default limits: not accepting ADD_ADDRs. Without the parent patch, the client is not able to establish new subflows using its 'subflow' endpoints. The parent commit fixes that. The 'Fixes' tag here below is the same as the one from the previous commit: this patch here is not fixing anything wrong in the selftests, but it validates the previous fix for an issue introduced by this commit ID. Fixes: df377be ("mptcp: add deny_join_id0 in mptcp_options_received") Cc: [email protected] Reviewed-by: Geliang Tang <[email protected]> Signed-off-by: Matthieu Baerts (NGI0) <[email protected]> Link: https://patch.msgid.link/20250925-net-next-mptcp-c-flag-laminar-v1-2-ad126cc47c6b@kernel.org Signed-off-by: Jakub Kicinski <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> (cherry picked from commit 86cade051b6724daf866dc936b7ec88c6d7ad416) Signed-off-by: Jack Vogel <[email protected]>
1 parent f0fbf1b commit 7eef451

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

tools/testing/selftests/net/mptcp/mptcp_join.sh

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3160,6 +3160,17 @@ deny_join_id0_tests()
31603160
run_tests $ns1 $ns2 10.0.1.1
31613161
chk_join_nr 1 1 1
31623162
fi
3163+
3164+
# default limits, server deny join id 0 + signal
3165+
if reset_with_allow_join_id0 "default limits, server deny join id 0" 0 1; then
3166+
pm_nl_set_limits $ns1 0 2
3167+
pm_nl_set_limits $ns2 0 2
3168+
pm_nl_add_endpoint $ns1 10.0.2.1 flags signal
3169+
pm_nl_add_endpoint $ns2 10.0.3.2 flags subflow
3170+
pm_nl_add_endpoint $ns2 10.0.4.2 flags subflow
3171+
run_tests $ns1 $ns2 10.0.1.1
3172+
chk_join_nr 2 2 2
3173+
fi
31633174
}
31643175

31653176
fullmesh_tests()

0 commit comments

Comments
 (0)