Skip to content

Commit df377be

Browse files
geliangtangdavem330
authored andcommitted
mptcp: add deny_join_id0 in mptcp_options_received
This patch added a new flag named deny_join_id0 in struct mptcp_options_received. Set it when MP_CAPABLE with the flag MPTCP_CAP_DENYJOIN_ID0 is received. Also add a new flag remote_deny_join_id0 in struct mptcp_pm_data. When the flag deny_join_id0 is set, set this remote_deny_join_id0 flag. In mptcp_pm_create_subflow_or_signal_addr, if the remote_deny_join_id0 flag is set, and the remote address id is zero, stop this connection. Suggested-by: Florian Westphal <[email protected]> Acked-by: Paolo Abeni <[email protected]> Signed-off-by: Geliang Tang <[email protected]> Signed-off-by: Mat Martineau <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent bab6b88 commit df377be

File tree

5 files changed

+15
-2
lines changed

5 files changed

+15
-2
lines changed

net/mptcp/options.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,9 @@ static void mptcp_parse_option(const struct sk_buff *skb,
8383
if (flags & MPTCP_CAP_CHECKSUM_REQD)
8484
mp_opt->csum_reqd = 1;
8585

86+
if (flags & MPTCP_CAP_DENY_JOIN_ID0)
87+
mp_opt->deny_join_id0 = 1;
88+
8689
mp_opt->mp_capable = 1;
8790
if (opsize >= TCPOLEN_MPTCP_MPC_SYNACK) {
8891
mp_opt->sndr_key = get_unaligned_be64(ptr);
@@ -360,6 +363,7 @@ void mptcp_get_options(const struct sock *sk,
360363
mp_opt->mp_prio = 0;
361364
mp_opt->reset = 0;
362365
mp_opt->csum_reqd = READ_ONCE(msk->csum_enabled);
366+
mp_opt->deny_join_id0 = 0;
363367

364368
length = (th->doff * 4) - sizeof(struct tcphdr);
365369
ptr = (const unsigned char *)(th + 1);
@@ -908,6 +912,9 @@ static bool check_fully_established(struct mptcp_sock *msk, struct sock *ssk,
908912
return false;
909913
}
910914

915+
if (mp_opt->deny_join_id0)
916+
WRITE_ONCE(msk->pm.remote_deny_join_id0, true);
917+
911918
if (unlikely(!READ_ONCE(msk->pm.server_side)))
912919
pr_warn_once("bogus mpc option on established client sk");
913920
mptcp_subflow_fully_established(subflow, mp_opt);

net/mptcp/pm.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -320,6 +320,7 @@ void mptcp_pm_data_init(struct mptcp_sock *msk)
320320
WRITE_ONCE(msk->pm.addr_signal, 0);
321321
WRITE_ONCE(msk->pm.accept_addr, false);
322322
WRITE_ONCE(msk->pm.accept_subflow, false);
323+
WRITE_ONCE(msk->pm.remote_deny_join_id0, false);
323324
msk->pm.status = 0;
324325

325326
spin_lock_init(&msk->pm.lock);

net/mptcp/pm_netlink.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,8 @@ static void mptcp_pm_create_subflow_or_signal_addr(struct mptcp_sock *msk)
451451

452452
/* check if should create a new subflow */
453453
if (msk->pm.local_addr_used < local_addr_max &&
454-
msk->pm.subflows < subflows_max) {
454+
msk->pm.subflows < subflows_max &&
455+
!READ_ONCE(msk->pm.remote_deny_join_id0)) {
455456
local = select_local_address(pernet, msk);
456457
if (local) {
457458
struct mptcp_addr_info remote = { 0 };

net/mptcp/protocol.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,8 @@ struct mptcp_options_received {
138138
mp_prio : 1,
139139
echo : 1,
140140
csum_reqd : 1,
141-
backup : 1;
141+
backup : 1,
142+
deny_join_id0 : 1;
142143
u32 token;
143144
u32 nonce;
144145
u64 thmac;
@@ -193,6 +194,7 @@ struct mptcp_pm_data {
193194
bool work_pending;
194195
bool accept_addr;
195196
bool accept_subflow;
197+
bool remote_deny_join_id0;
196198
u8 add_addr_signaled;
197199
u8 add_addr_accepted;
198200
u8 local_addr_used;

net/mptcp/subflow.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -408,6 +408,8 @@ static void subflow_finish_connect(struct sock *sk, const struct sk_buff *skb)
408408

409409
if (mp_opt.csum_reqd)
410410
WRITE_ONCE(mptcp_sk(parent)->csum_enabled, true);
411+
if (mp_opt.deny_join_id0)
412+
WRITE_ONCE(mptcp_sk(parent)->pm.remote_deny_join_id0, true);
411413
subflow->mp_capable = 1;
412414
subflow->can_ack = 1;
413415
subflow->remote_key = mp_opt.sndr_key;

0 commit comments

Comments
 (0)