Skip to content

Conversation

codewithsathish9094
Copy link
Member

@codewithsathish9094 codewithsathish9094 commented Sep 30, 2025

w.r.t the commit on convert_oci_tool_call_to_langchain . We are getting below error

File "/Users/sathraje/.venv/lib/python3.11/site-packages/langchain_oci/chat_models/oci_generative_ai.py", line 100, in convert_oci_tool_call_to_langchain
    if "arguments" in tool_call.attribute_map
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: argument of type 'NoneType' is not iterable

Proposing a change to make the code more defensive,

File "/Users/sathraje/.venv/lib/python3.11/site-packages/langchain_oci/chat_models/oci_generative_ai.py", line 100, in convert_oci_tool_call_to_langchain
    if "arguments" in tool_call.attribute_map
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: argument of type 'NoneType' is not iterable
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Sep 30, 2025
@YouNeedCryDear YouNeedCryDear self-requested a review September 30, 2025 17:58
@YouNeedCryDear YouNeedCryDear self-requested a review September 30, 2025 20:43
@codewithsathish9094
Copy link
Member Author

OCA is approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Required At least one contributor does not have an approved Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants