Scan new versions for existing libraries #552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnestoro
force-pushed
the
dnestoro/CreateLibraryVersionsDependabot
branch
from
7c25881 to
2a338c9
Compare
dnestoro
force-pushed
the
dnestoro/CreateLibraryVersionsDependabot
branch
from
f61dc30 to
0841c01
Compare
vjovanov
reviewed
Oct 31, 2024
vjovanov
reviewed
Oct 31, 2024
tests/tck-build-logic/src/main/groovy/org.graalvm.internal.tck-harness.gradle
Outdated
Show resolved
Hide resolved
vjovanov
reviewed
Oct 31, 2024
tests/tck-build-logic/src/main/groovy/org.graalvm.internal.tck-harness.gradle
Outdated
Show resolved
Hide resolved
vjovanov
reviewed
Oct 31, 2024
tests/tck-build-logic/src/main/groovy/org.graalvm.internal.tck-harness.gradle
Outdated
Show resolved
Hide resolved
vjovanov
reviewed
Oct 31, 2024
tests/tck-build-logic/src/main/groovy/org.graalvm.internal.tck-harness.gradle
Outdated
Show resolved
Hide resolved
vjovanov
reviewed
Oct 31, 2024
tests/tck-build-logic/src/main/groovy/org.graalvm.internal.tck-harness.gradle
Outdated
Show resolved
Hide resolved
Member
|
This PR requires a detailed explanation (in the form of docs) on how the new version is computed. |
fniephaus
reviewed
Nov 6, 2024
tests/tck-build-logic/src/main/groovy/org.graalvm.internal.tck-harness.gradle
Outdated
Show resolved
Hide resolved
tests/tck-build-logic/src/main/groovy/org/graalvm/internal/tck/harness/TckExtension.java
Outdated
Show resolved
Hide resolved
tests/tck-build-logic/src/main/groovy/org/graalvm/internal/tck/harness/TckExtension.java
Outdated
Show resolved
Hide resolved
tests/tck-build-logic/src/main/java/org/graalvm/internal/tck/TestedVersionUpdaterTask.java
Outdated
Show resolved
Hide resolved
Member
Author
Maybe we should start some kind of infrastructure changelog? |
melix
requested changes
Nov 7, 2024
Member
melix
left a comment
melix
left a comment
There was a problem hiding this comment.
Functionally-wise, sounds good to me. The implementation however needs a couple reworks to be Gradle idiomatic (and not break up-to-date checking/configuration).
tests/tck-build-logic/src/main/groovy/org.graalvm.internal.tck-harness.gradle
Outdated
Show resolved
Hide resolved
tests/tck-build-logic/src/main/groovy/org.graalvm.internal.tck-harness.gradle
Outdated
Show resolved
Hide resolved
tests/tck-build-logic/src/main/java/org/graalvm/internal/tck/TestedVersionUpdaterTask.java
Show resolved
Hide resolved
tests/tck-build-logic/src/main/java/org/graalvm/internal/tck/TestedVersionUpdaterTask.java
Outdated
Show resolved
Hide resolved
tests/tck-build-logic/src/main/java/org/graalvm/internal/tck/TestedVersionUpdaterTask.java
Outdated
Show resolved
Hide resolved
melix
requested changes
Nov 8, 2024
...vy/org/graalvm/internal/tck/harness/tasks/FetchExistingLibrariesWithNewerVersionsTask.groovy
Outdated
Show resolved
Hide resolved
...vy/org/graalvm/internal/tck/harness/tasks/FetchExistingLibrariesWithNewerVersionsTask.groovy
Outdated
Show resolved
Hide resolved
melix
approved these changes
Nov 8, 2024
vjovanov
reviewed
Nov 12, 2024
vjovanov
approved these changes
Nov 12, 2024
fniephaus
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces a new GitHub workflow that scans for newer versions of libraries that currently exist in the repo.
When there is a newer version available, we are trying to run existing tests with existing metadata to verify if tests can pass.
tested-versionslist in the correspondingindex.jsonfile. Accumulated results will be provided through an automatically created PR.NOTE: we must allow github actions to create PRs automatically.