[GR-55278] [GR-58056] Collect all external values for Layered Image #9905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static final fields were previously missed when encoding graphs for Layered Image, which caused a lot of objects to be wrongly recreated instead of referring to the static field in the extension images.
The external values are now correctly collected.
This allows to reduce the size of the
.nibfile by around 900MB (from 4.29GB to 3.39GB).The graphs that were previously containing a
$$Lambdareference do not contain it anymore and can be persisted without issues.The
VMThreadLocalInfoandCGlobalDataInfoare properly registered to avoid ghost objects.