[GR-57998] Remove ComputedValueField and ReadableJavaField. #9634
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have proper
FieldValueTransformer, it is no longer necessary to also haveComputedValueFieldto do the transformations for@RecomputeFieldValueannotations. Instead,AnnotationSubstitutionProcessornow registers field value transformer too.Only for the weird and historic final field semantics of
@Aliasfields, it is still necessary to haveAliasFieldin the substitution universe. ButAliasFieldis much simpler than the oldComputedValueField.With
ComputedValueFieldgone, there is also no need forReadableJavaField.In addition, there is also no longer a need for the
Availabilityenum inFieldValueTransformerWithAvailabiliy. A simpleboolean isAvailablemethod is sufficient and more flexible.This PR should not have much impact on analysis or code quality. There is only a slight possible benefit: the field value transformer for
FieldOffsettransformations allows intrisification before the analysis, which can turn a few unsafe field accesses back into regular field access nodes.