Skip to content

[GR-47712] Report error if building static executable without musl libc. #8403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2024
Merged

[GR-47712] Report error if building static executable without musl libc. #8403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/SubstrateOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,10 @@ public class SubstrateOptions {
if (!Platform.includedIn(Platform.LINUX.class)) {
throw UserError.invalidOptionValue(key, key.getValue(), "Building static executable images is currently only supported on Linux. Remove the '--static' option or build on a Linux machine");
}
if (!LibCBase.targetLibCIs(MuslLibC.class)) {
throw UserError.invalidOptionValue(key, key.getValue(),
"Building static executable images is only supported with musl libc. Remove the '--static' option or add the '--libc=musl' option.");
}
});

@APIOption(name = "libc")//
Expand Down
7 changes: 4 additions & 3 deletions .../com.oracle.svm.core/src/com/oracle/svm/core/option/ValidateImageBuildOptionsFeature.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,16 @@
package com.oracle.svm.core.option;

import org.graalvm.collections.UnmodifiableMapCursor;
import jdk.graal.compiler.options.OptionKey;

import com.oracle.svm.core.feature.InternalFeature;
import com.oracle.svm.core.feature.AutomaticallyRegisteredFeature;
import com.oracle.svm.core.feature.InternalFeature;

import jdk.graal.compiler.options.OptionKey;

@AutomaticallyRegisteredFeature
public class ValidateImageBuildOptionsFeature implements InternalFeature {
@Override
public void afterRegistration(AfterRegistrationAccess access) {
public void beforeAnalysis(BeforeAnalysisAccess access) {
UnmodifiableMapCursor<OptionKey<?>, Object> cursor = RuntimeOptionValues.singleton().getMap().getEntries();
while (cursor.advance()) {
validate(cursor.getKey());
Expand Down