Skip to content

Conversation

@graalvmbot
Copy link
Collaborator

Now that ParseOnce is the only execution mode, and ResolvedSignature can provide better typing for signatures, this PR improves typing and removes explicit type checks.

  • In GraphProvider.buildGraph, pass in AnalysisMethod to remove later explicit casts.
  • Remove SubstrateGraphKit.loadArguments. It is just silly to load arguments based on the method signature (which could be the wrong signature), we can just collect the arguments when the FrameStateBuilder creates them.
  • Return a typed signature from AnalysisMethod.getSignature and HostedMethod.getSignature and remove later explicit casts.
  • Use the getParameterType and getReturnType methods of ResolvedSignature that do not need an accessingClass parameter.
  • Use ResolvedSignature.toParameterList where appropriate and remove later explicit casts.
  • Replace SimpleSignature with ResolvedSignature
  • Do not use ResolvedJavaMethod.toParameterTypes because it is badly defined for constructors. Overrides in AnalysisMethod and HostedMethod prevent future usage in our universe.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 8, 2023
@graalvmbot graalvmbot closed this Dec 9, 2023
@graalvmbot graalvmbot deleted the cwi/GR-50426-Signature-3 branch December 9, 2023 08:07
@graalvmbot graalvmbot merged commit f60f913 into master Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants