Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -554,6 +554,16 @@ public static final boolean hasColorsEnabled(OptionValues values) {
@Option(help = "How many bytes to pad fields and classes marked @Contended with.") //
public static final HostedOptionKey<Integer> ContendedPaddingWidth = new HostedOptionKey<>(128);

@Option(help = "Add additional header bytes to each object, for diagnostic purposes.", type = OptionType.Debug) //
public static final HostedOptionKey<Integer> AdditionalHeaderBytes = new HostedOptionKey<>(0, SubstrateOptions::validateAdditionalHeaderBytes);

private static void validateAdditionalHeaderBytes(HostedOptionKey<Integer> optionKey) {
int value = optionKey.getValue();
if (value < 0 || value % 4 != 0) {
throw UserError.abort("The option '%s' must be 0 or a multiple of 4.", optionKey.getName());
}
}

/*
* Isolate tear down options.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@
*/
package com.oracle.svm.core.config;

import jdk.graal.compiler.api.directives.GraalDirectives;
import jdk.graal.compiler.core.common.NumUtil;
import jdk.graal.compiler.replacements.ReplacementsUtil;
import org.graalvm.nativeimage.AnnotationAccess;
import org.graalvm.nativeimage.c.constant.CEnum;
import org.graalvm.word.WordBase;
Expand All @@ -35,6 +32,9 @@
import com.oracle.svm.core.Uninterruptible;
import com.oracle.svm.core.deopt.DeoptimizedFrame;

import jdk.graal.compiler.api.directives.GraalDirectives;
import jdk.graal.compiler.core.common.NumUtil;
import jdk.graal.compiler.replacements.ReplacementsUtil;
import jdk.vm.ci.code.CodeUtil;
import jdk.vm.ci.code.TargetDescription;
import jdk.vm.ci.meta.JavaKind;
Expand All @@ -60,6 +60,7 @@ public ObjectLayout(SubstrateTargetDescription target, int referenceSize, int ob
int firstFieldOffset, int arrayLengthOffset, int arrayBaseOffset, int fixedIdentityHashOffset) {
assert CodeUtil.isPowerOf2(referenceSize) : referenceSize;
assert CodeUtil.isPowerOf2(objectAlignment) : objectAlignment;
assert arrayLengthOffset % Integer.BYTES == 0;
assert hubOffset < firstFieldOffset && hubOffset < arrayLengthOffset : hubOffset;
assert fixedIdentityHashOffset == -1 || (fixedIdentityHashOffset > 0 && fixedIdentityHashOffset < arrayLengthOffset) : fixedIdentityHashOffset;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,6 @@
import java.util.Optional;
import java.util.Set;

import jdk.graal.compiler.api.replacements.SnippetReflectionProvider;
import jdk.graal.compiler.core.common.CompressEncoding;
import jdk.graal.compiler.core.common.spi.MetaAccessExtensionProvider;
import jdk.graal.compiler.debug.DebugContext;
import jdk.graal.compiler.nodes.StructuredGraph;
import jdk.graal.compiler.options.OptionValues;
import org.graalvm.nativeimage.ImageSingletons;
import org.graalvm.nativeimage.Platform;

Expand Down Expand Up @@ -76,6 +70,12 @@
import com.oracle.svm.hosted.meta.HostedUniverse;
import com.oracle.svm.hosted.substitute.UnsafeAutomaticSubstitutionProcessor;

import jdk.graal.compiler.api.replacements.SnippetReflectionProvider;
import jdk.graal.compiler.core.common.CompressEncoding;
import jdk.graal.compiler.core.common.spi.MetaAccessExtensionProvider;
import jdk.graal.compiler.debug.DebugContext;
import jdk.graal.compiler.nodes.StructuredGraph;
import jdk.graal.compiler.options.OptionValues;
import jdk.internal.ValueBased;
import jdk.vm.ci.meta.JavaKind;
import jdk.vm.ci.meta.MetaAccessProvider;
Expand Down Expand Up @@ -138,13 +138,13 @@ public static ObjectLayout createObjectLayout() {
public static ObjectLayout createObjectLayout(JavaKind referenceKind, boolean disableOptionalIdentityHash) {
SubstrateTargetDescription target = ConfigurationValues.getTarget();
int referenceSize = target.arch.getPlatformKind(referenceKind).getSizeInBytes();
int headerSize = referenceSize;
int intSize = target.arch.getPlatformKind(JavaKind.Int).getSizeInBytes();
int objectAlignment = 8;

int headerOffset = 0;
int hubOffset = 0;
int headerSize = hubOffset + referenceSize;

int identityHashCodeOffset;
int firstFieldOffset;
if (!disableOptionalIdentityHash && SubstrateOptions.SpawnIsolates.getValue() && headerSize + referenceSize <= objectAlignment) {
/*
* References are relative to the heap base, so we should be able to use fewer bits in
Expand All @@ -156,15 +156,18 @@ public static ObjectLayout createObjectLayout(JavaKind referenceKind, boolean di
* individual object was assigned an identity hash code after allocation.
*/
identityHashCodeOffset = -1;
firstFieldOffset = headerOffset + headerSize;
} else { // need all object header bits except for lowest-order bits freed up by alignment
identityHashCodeOffset = headerOffset + referenceSize;
firstFieldOffset = identityHashCodeOffset + intSize;
identityHashCodeOffset = headerSize;
headerSize += intSize;
}
int arrayLengthOffset = firstFieldOffset;

headerSize += SubstrateOptions.AdditionalHeaderBytes.getValue();

int firstFieldOffset = headerSize;
int arrayLengthOffset = headerSize;
int arrayBaseOffset = arrayLengthOffset + intSize;

return new ObjectLayout(target, referenceSize, objectAlignment, headerOffset, firstFieldOffset, arrayLengthOffset, arrayBaseOffset, identityHashCodeOffset);
return new ObjectLayout(target, referenceSize, objectAlignment, hubOffset, firstFieldOffset, arrayLengthOffset, arrayBaseOffset, identityHashCodeOffset);
}

public SVMHost createHostVM(OptionValues options, ClassLoader classLoader, ClassInitializationSupport classInitializationSupport,
Expand Down