Skip to content

[GR-41614] Move resource registration to beforeAnalysis phase #7670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 54 commits into from
Oct 26, 2023
Merged

[GR-41614] Move resource registration to beforeAnalysis phase #7670

merged 54 commits into from
Oct 26, 2023

Conversation

@graalvmbot
Copy link
Collaborator

@graalvmbot graalvmbot commented Oct 26, 2023

No description provided.

dnestoro added 30 commits October 24, 2023 16:03
@dnestoro
Move resource registration to beforeAnalysis phase
a180a4b
@dnestoro
Try to speed resource traversing by introducing parallelism
252861c
@dnestoro
Change function that public API uses to register resource
ee5f501
@dnestoro
Add resource registration through API without patterns
f3e5980
@dnestoro
Try to open modules and decide whether resource comes from jar
7865a6c
@dnestoro
Replace CharsetSubstitution resource adding
705835d
@dnestoro
Change addResource function to check whether the entry is directory o…
eaafc3d 
…r not
@dnestoro
Extract resource adding from beforeAnalysis to duringSetup in Truffle…
82fdd40 
…BaseFeature
@dnestoro
Extract bunndles registration from pattern based addResources
5e71750
@dnestoro
Replace resource Bundles registration with non-pattern-based implemen…
1468ef1 
…tation
@dnestoro
Add null pointer check for module classLoader
55c9af1
@dnestoro
Add .properties extension to resourceBundle name
5d53612
@dnestoro
Add module lookup map
5633755
@dnestoro
Add unnamed module case
fa166d8
@dnestoro
Move resource adding to duringSetup when the RuntimeResourceSupport i…
2b762d9 
…s added to singletones
@dnestoro
Try to match resource pattern
b4ca2f2
@dnestoro
Cover the case when resource has condition
8a7f024
@dnestoro
Add conditional resource directory registration test
7a34bb3
@dnestoro
Refactor adding content to directory resource
8b02c19
@dnestoro
Replace pairs with records to get more semantic
f2a4fbc
@dnestoro
Get content for directories inside jar
f49fe93
@dnestoro
Add possiblity to register resource for various conditions
a5ca553
@dnestoro
Prevent registration of same resources multiple times
1f28251
@dnestoro
Resolve conflicts
130eb2a
@dnestoro
Remove exceptions that could not be thrown from method signature
18a1797
@dnestoro
Remove unused import from mx file
08167ef
@dnestoro
Revert locale argument for prepareBundle function
12aa181
@dnestoro
Add missing throw when using VMError
de5d307
@dnestoro
Replace findModule with Class.class.getModule for java.base scenario
fb8105d
@dnestoro
Remove comments from prepareBundle
69646bc
dnestoro added 24 commits October 24, 2023 16:05
@dnestoro
Add null check guard for findModule
9c59901
@dnestoro
Remove redudant functions and improve duplicates checking
03854b2
@dnestoro
Register negative query directories
9b9ed1f
@dnestoro
Fix package export from module
167a727
@dnestoro
Remove redudant parameters from resource registration functions
620f813
@dnestoro
Remove sufficient prints
2e76995
@dnestoro
Cover case when same resource name can occur in multiple bundles
1635c2b
@dnestoro
Restructure code for better readability
52d9e72
@dnestoro
Add synchronization for alreadyAddedResources check
0f90072
@dnestoro
Cleanup code
17f84cc
@dnestoro
Convert ResorucePattern class to record
45c27ed
@dnestoro
Remove debugg context since it is not used anymore
30e5c86
@dnestoro
Add explanation for shouldRegisterResource function
c898d38
@dnestoro
Add function that is never used just to pass gates
0853a1c
@dnestoro
Replace module export with module open access
56bdd98
@dnestoro
Update imports according to changes on master
e1807e0
@dnestoro
Inline function and remove passing null for findModule function
ec0913f
@dnestoro
Avoid using synchronized block all the time
9de65c8
@dnestoro
Replace multiple calls of string transformation with function
2da282f
@dnestoro
Extract directory registration handling form registerResoruce function
4b9c4d7
@dnestoro
Rebase and fix imports
f54f22c
@dnestoro
Rename includeAll variable to includeCurrent
9f793ce
@dnestoro
Use Resources#registerIOException instead of ignoring exception
e006dd4
@dnestoro
Revert overridden prepareBundle function because it can be called fro…
b552181 
…m other places
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 26, 2023
@graalvmbot graalvmbot merged commit 8b67e3f into master Oct 26, 2023
@graalvmbot graalvmbot deleted the dnestoro/GR-41614/MoveResourceRegistrationToBeforeAnalysis branch October 26, 2023 15:58
This was referenced Nov 10, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@graalvmbot @dnestoro