[23.1] Backport: [GR-49300] Break the initialization cycle in NIO/cgroups code #7574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
zakkak
changed the title
2 tasks
jerboaa
reviewed
Oct 10, 2023
substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/heap/PhysicalMemory.java
Outdated
Show resolved
Hide resolved
zakkak
force-pushed
the
2023-10-10-backport-7553
branch
2 times, most recently
from
9a77c83 to
285747b
Compare
Collaborator
Author
|
Not sure why ecj compilation fails with this, but not in the original PR. |
Collaborator
|
@ezzarghili Any update on this? Thanks! |
Collaborator
|
@zakkak Could you please fix the checkstyle issue? |
First, we use a separate accessor for page-alignedness as it doesn't need the more sophisticated initialization of the directMemory field. Next, ensure PhysicalMemory initialization is serialized and when it is, set directMemory to a static value so that the container code can finish initialization without introducing a cyle. The final directMemory value based on the heap size is then published to JDK code by setting the VM init level to 1. Therefore, application code would use the non-static value as the upper bound. Closes: oracle#556 (cherry picked from commit 1ae2dc0)
(cherry picked from commit 318f108)
…ore thread-safe way. (cherry picked from commit af74d9f)
…#MAX_MEMORY. (cherry picked from commit a606940)
zakkak
force-pushed
the
2023-10-10-backport-7553
branch
from
285747b to
1d2c7c1
Compare
Collaborator
Author
Done |
Collaborator
Author
|
Hi @ezzarghili, this is a kind reminder. |
Member
|
This was already backported to 23.1 internally on GR-49328 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7553
Conflicts were trivially resolved by accepting the new changes over the old ones.
@jerboaa can you please review?