[GR-47109] Implement JFR Event Throttling.

substratevm/CHANGELOG.md

@@ -6,6 +6,7 @@ This changelog summarizes major changes to GraalVM Native Image.
 * (GR-48304) Red Hat added support for the JFR event ThreadAllocationStatistics.
 * (GR-48343) Red Hat added support for the JFR events AllocationRequiringGC and SystemGC.
 * (GR-48612) Enable `--strict-image-heap` by default. The option is now deprecated and can be removed from your argument list. A blog post with more information will follow shortly.
+* (GR-47109) JFR event throttling support was added, along with the jdk.ObjectAllocationSample event.
 * (GR-48354) Remove native-image-agent legacy `build`-option
 * (GR-49221) Support for thread dumps can now be enabled with `--enable-monitoring=threaddump`. The option `-H:±DumpThreadStacksOnSignal` is deprecated and marked for removal.
 * (GR-48579) Options ParseOnce, ParseOnceJIT, and InlineBeforeAnalysis are deprecated and no longer have any effect.

substratevm/src/com.oracle.svm.core.genscavenge/src/com/oracle/svm/core/genscavenge/ThreadLocalAllocation.java

@@ -62,7 +62,7 @@
 import com.oracle.svm.core.hub.DynamicHub;
 import com.oracle.svm.core.hub.LayoutEncoding;
 import com.oracle.svm.core.jfr.JfrTicks;
-import com.oracle.svm.core.jfr.events.ObjectAllocationInNewTLABEvent;
+import com.oracle.svm.core.jfr.events.JfrAllocationEvents;
 import com.oracle.svm.core.log.Log;
 import com.oracle.svm.core.snippets.KnownIntrinsics;
 import com.oracle.svm.core.snippets.SubstrateForeignCallTarget;
@@ -238,7 +238,7 @@ private static Object slowPathNewInstanceWithoutAllocating(DynamicHub hub) {
             AlignedHeader newTlab = HeapImpl.getChunkProvider().produceAlignedChunk();
             return allocateInstanceInNewTlab(hub, size, newTlab);
         } finally {
-            ObjectAllocationInNewTLABEvent.emit(startTicks, hub, size, HeapParameters.getAlignedHeapChunkSize());
+            JfrAllocationEvents.emit(startTicks, hub, size, HeapParameters.getAlignedHeapChunkSize());
             DeoptTester.enableDeoptTesting();
         }
     }
@@ -319,7 +319,7 @@ private static Object slowPathNewArrayLikeObject0(DynamicHub hub, int length, Un
             }
             return array;
         } finally {
-            ObjectAllocationInNewTLABEvent.emit(startTicks, hub, size, tlabSize);
+            JfrAllocationEvents.emit(startTicks, hub, size, tlabSize);
             DeoptTester.enableDeoptTesting();
         }
     }

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jdk/UninterruptibleUtils.java

@@ -438,6 +438,17 @@ public static int abs(int a) {
         public static long abs(long a) {
             return (a < 0) ? -a : a;
         }
+
+        @Uninterruptible(reason = "Called from uninterruptible code.", mayBeInlined = true)
+        public static long floor(double a) {
+            return (long) a;
+        }
+
+        @Uninterruptible(reason = "Called from uninterruptible code.", mayBeInlined = true)
+        public static long ceil(double a) {
+            long floor = floor(a);
+            return a > floor ? floor + 1 : floor;
+        }
     }
 
     public static class Byte {

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jfr/JfrEvent.java

@@ -30,57 +30,75 @@
 import com.oracle.svm.core.Uninterruptible;
 import com.oracle.svm.core.thread.JavaThreads;
 
+import java.util.ArrayList;
+import java.util.List;
+
 /**
  * This file contains the VM-level events that Native Image supports on all JDK versions. The event
  * IDs depend on the JDK version (see metadata.xml file) and are computed at image build time.
  */
 public final class JfrEvent {
-    public static final JfrEvent ThreadStart = create("jdk.ThreadStart", false);
-    public static final JfrEvent ThreadEnd = create("jdk.ThreadEnd", false);
-    public static final JfrEvent ThreadCPULoad = create("jdk.ThreadCPULoad", false);
-    public static final JfrEvent DataLoss = create("jdk.DataLoss", false);
-    public static final JfrEvent ClassLoadingStatistics = create("jdk.ClassLoadingStatistics", false);
-    public static final JfrEvent InitialEnvironmentVariable = create("jdk.InitialEnvironmentVariable", false);
-    public static final JfrEvent InitialSystemProperty = create("jdk.InitialSystemProperty", false);
-    public static final JfrEvent JavaThreadStatistics = create("jdk.JavaThreadStatistics", false);
-    public static final JfrEvent JVMInformation = create("jdk.JVMInformation", false);
-    public static final JfrEvent OSInformation = create("jdk.OSInformation", false);
-    public static final JfrEvent PhysicalMemory = create("jdk.PhysicalMemory", false);
-    public static final JfrEvent ExecutionSample = create("jdk.ExecutionSample", false);
-    public static final JfrEvent NativeMethodSample = create("jdk.NativeMethodSample", false);
-    public static final JfrEvent GarbageCollection = create("jdk.GarbageCollection", true);
-    public static final JfrEvent GCPhasePause = create("jdk.GCPhasePause", true);
-    public static final JfrEvent GCPhasePauseLevel1 = create("jdk.GCPhasePauseLevel1", true);
-    public static final JfrEvent GCPhasePauseLevel2 = create("jdk.GCPhasePauseLevel2", true);
-    public static final JfrEvent GCPhasePauseLevel3 = create("jdk.GCPhasePauseLevel3", true);
-    public static final JfrEvent GCPhasePauseLevel4 = create("jdk.GCPhasePauseLevel4", true);
-    public static final JfrEvent SafepointBegin = create("jdk.SafepointBegin", true);
-    public static final JfrEvent SafepointEnd = create("jdk.SafepointEnd", true);
-    public static final JfrEvent ExecuteVMOperation = create("jdk.ExecuteVMOperation", true);
-    public static final JfrEvent JavaMonitorEnter = create("jdk.JavaMonitorEnter", true);
-    public static final JfrEvent ThreadPark = create("jdk.ThreadPark", true);
-    public static final JfrEvent JavaMonitorWait = create("jdk.JavaMonitorWait", true);
-    public static final JfrEvent JavaMonitorInflate = create("jdk.JavaMonitorInflate", true);
-    public static final JfrEvent ObjectAllocationInNewTLAB = create("jdk.ObjectAllocationInNewTLAB", false);
-    public static final JfrEvent GCHeapSummary = create("jdk.GCHeapSummary", false);
-    public static final JfrEvent ThreadAllocationStatistics = create("jdk.ThreadAllocationStatistics", false);
-    public static final JfrEvent SystemGC = create("jdk.SystemGC", true);
-    public static final JfrEvent AllocationRequiringGC = create("jdk.AllocationRequiringGC", false);
-
+    private static final List<JfrEvent> events = new ArrayList<>();
+    public static final JfrEvent ThreadStart = create("jdk.ThreadStart", false, false);
+    public static final JfrEvent ThreadEnd = create("jdk.ThreadEnd", false, false);
+    public static final JfrEvent ThreadCPULoad = create("jdk.ThreadCPULoad", false, false);
+    public static final JfrEvent DataLoss = create("jdk.DataLoss", false, false);
+    public static final JfrEvent ClassLoadingStatistics = create("jdk.ClassLoadingStatistics", false, false);
+    public static final JfrEvent InitialEnvironmentVariable = create("jdk.InitialEnvironmentVariable", false, false);
+    public static final JfrEvent InitialSystemProperty = create("jdk.InitialSystemProperty", false, false);
+    public static final JfrEvent JavaThreadStatistics = create("jdk.JavaThreadStatistics", false, false);
+    public static final JfrEvent JVMInformation = create("jdk.JVMInformation", false, false);
+    public static final JfrEvent OSInformation = create("jdk.OSInformation", false, false);
+    public static final JfrEvent PhysicalMemory = create("jdk.PhysicalMemory", false, false);
+    public static final JfrEvent ExecutionSample = create("jdk.ExecutionSample", false, false);
+    public static final JfrEvent NativeMethodSample = create("jdk.NativeMethodSample", false, false);
+    public static final JfrEvent GarbageCollection = create("jdk.GarbageCollection", true, false);
+    public static final JfrEvent GCPhasePause = create("jdk.GCPhasePause", true, false);
+    public static final JfrEvent GCPhasePauseLevel1 = create("jdk.GCPhasePauseLevel1", true, false);
+    public static final JfrEvent GCPhasePauseLevel2 = create("jdk.GCPhasePauseLevel2", true, false);
+    public static final JfrEvent GCPhasePauseLevel3 = create("jdk.GCPhasePauseLevel3", true, false);
+    public static final JfrEvent GCPhasePauseLevel4 = create("jdk.GCPhasePauseLevel4", true, false);
+    public static final JfrEvent SafepointBegin = create("jdk.SafepointBegin", true, false);
+    public static final JfrEvent SafepointEnd = create("jdk.SafepointEnd", true, false);
+    public static final JfrEvent ExecuteVMOperation = create("jdk.ExecuteVMOperation", true, false);
+    public static final JfrEvent JavaMonitorEnter = create("jdk.JavaMonitorEnter", true, false);
+    public static final JfrEvent ThreadPark = create("jdk.ThreadPark", true, false);
+    public static final JfrEvent JavaMonitorWait = create("jdk.JavaMonitorWait", true, false);
+    public static final JfrEvent JavaMonitorInflate = create("jdk.JavaMonitorInflate", true, false);
+    public static final JfrEvent ObjectAllocationInNewTLAB = create("jdk.ObjectAllocationInNewTLAB", false, false);
+    public static final JfrEvent GCHeapSummary = create("jdk.GCHeapSummary", false, false);
+    public static final JfrEvent ThreadAllocationStatistics = create("jdk.ThreadAllocationStatistics", false, false);
+    public static final JfrEvent SystemGC = create("jdk.SystemGC", true, false);
+    public static final JfrEvent AllocationRequiringGC = create("jdk.AllocationRequiringGC", false, false);
+    public static final JfrEvent ObjectAllocationSample = create("jdk.ObjectAllocationSample", false, true);
     private final long id;
     private final String name;
     private final boolean hasDuration;
+    private JfrThrottler throttler;
 
     @Platforms(Platform.HOSTED_ONLY.class)
-    public static JfrEvent create(String name, boolean hasDuration) {
-        return new JfrEvent(name, hasDuration);
+    public static JfrEvent create(String name, boolean hasDuration, boolean hasThrottling) {
+        return new JfrEvent(name, hasDuration, hasThrottling);
     }
 
     @Platforms(Platform.HOSTED_ONLY.class)
-    private JfrEvent(String name, boolean hasDuration) {
+    private JfrEvent(String name, boolean hasDuration, boolean hasThrottling) {
         this.id = JfrMetadataTypeLibrary.lookupPlatformEvent(name);
         this.name = name;
         this.hasDuration = hasDuration;
+        if (hasThrottling) {
+            throttler = new JfrThrottler();
+        }
+        events.add(this);
+    }
+
+    public static List<JfrEvent> getEvents() {
+        return events;
+    }
+
+    @Uninterruptible(reason = "Called from uninterruptible code.", mayBeInlined = true)
+    public JfrThrottler getThrottler() {
+        return throttler;
     }
 
     @Uninterruptible(reason = "Called from uninterruptible code.", mayBeInlined = true)
@@ -113,6 +131,6 @@ public boolean shouldEmit(long durationTicks) {
 
     @Uninterruptible(reason = "Prevent races with VM operations that start/stop recording.", callerMustBe = true)
     private boolean shouldEmit0() {
-        return SubstrateJVM.get().isRecording() && SubstrateJVM.get().isEnabled(this);
+        return SubstrateJVM.get().shouldCommit(this) && SubstrateJVM.get().isRecording() && SubstrateJVM.get().isEnabled(this);
     }
 }

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jfr/JfrManager.java

@@ -86,6 +86,7 @@ public RuntimeSupport.Hook startupHook() {
         return isFirstIsolate -> {
             parseFlightRecorderLogging(SubstrateOptions.FlightRecorderLogging.getValue());
             periodicEventSetup();
+            SubstrateJVM.getJfrRandom().resetSeed();
             if (isJFREnabled()) {
                 initRecording();
             }