Skip to content

Conversation

@zakkak
Copy link
Collaborator

@zakkak zakkak commented Jun 6, 2023

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 6, 2023
@zakkak zakkak requested a review from fniephaus June 6, 2023 11:31
@christianhaeubl christianhaeubl requested a review from zapster June 6, 2023 11:32
@zakkak
Copy link
Collaborator Author

zakkak commented Jun 6, 2023

For the record, the strict tag checking was added to mx with graalvm/mx@b209e64

@zapster
Copy link
Member

zapster commented Jun 6, 2023

Thanks @zakkak for the fix. I guess the tags were originally added to test something but we did not notice they no longer exist (that is what motivates the strict tag checking in the first place). So we should probably replace them with something else. Some suggestions in-line.

@zakkak zakkak force-pushed the 2023-06-06-fix-ci branch from f658f09 to 76f4a2a Compare June 6, 2023 12:25
Copy link
Member

@zapster zapster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again. I'll integrate it ASAP.

@zakkak zakkak removed the request for review from fniephaus June 6, 2023 12:43
@graalvmbot graalvmbot merged commit e692a5f into oracle:master Jun 6, 2023
@zakkak zakkak deleted the 2023-06-06-fix-ci branch June 6, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants