[GR-44722] Inherit java.vendor.version from host VM.
#6377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
jerboaa
approved these changes
Apr 6, 2023
Collaborator
jerboaa
left a comment
jerboaa
left a comment
There was a problem hiding this comment.
Looks fine. Thanks for the quick fix.
This fixes Version.getCurrent() invocations for builds, not modifying the base JDK. Closes: #6379
Member
|
Thanks, @jerboaa. I noticed that the proposed behavior is slightly different to what it was before, so I restored the original behavior (default to |
graalvmbot
force-pushed
the
fniephaus/GR-44722/inherit-vendor-version
branch
from
e0ce636 to
a4f0786
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets Native Image inherit the vendor version from the host VM (unless
org.graalvm.vendorversionis set). The full vendor version of a GraalVM CE host VM indicates whether a build is a dev build (optional-devinfix) and includes a GraalVM-specific build number (.1suffix). This vendor version is displayed as part of the version string of Native Image: