-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[GR-45044] Avoid emitting rmi library.
#6250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@roberttoyonaga could you take a look at this please? |
0d67f8c to
f23c6e4
Compare
roberttoyonaga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
Can you please add RuntimeReflection.register(access.findClassByName("sun.rmi.server.UnicastRef2").getConstructors()); to the JMXClientFeature reflection config? It isn't related to your changes here, but is fixes a bug I caught while testing these changes.
You can also remove RuntimeReflection.register(access.findClassByName("sun.rmi.server.UnicastRef").getMethods()); I don't think its actually needed
...ratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/jdk/JDKInitializationFeature.java
Show resolved
Hide resolved
|
Thanks for the quick review!
Any way we can add a test for this? |
Hi Fabio, yes I can create a follow up PR with the test |
Sure, that'd work but then, I'd prefer if you also do the |
ok yes that makes sense |
It is not needed as it only provides an implementation for `maxObjectInspectionAge()`, which is substituted in SVM.
f23c6e4 to
d054444
Compare
It is not needed as it only provides an implementation for
maxObjectInspectionAge(), which is substituted in SVM.