Skip to content

Conversation

@graalvmbot
Copy link
Collaborator

It is not needed as it only provides an implementation for maxObjectInspectionAge(), which is substituted in SVM.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 21, 2023
@fniephaus
Copy link
Member

@roberttoyonaga could you take a look at this please?

@graalvmbot graalvmbot force-pushed the fniephaus/GR-45044/drop-rmi branch from 0d67f8c to f23c6e4 Compare March 21, 2023 13:50
Copy link
Collaborator

@roberttoyonaga roberttoyonaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

Can you please add RuntimeReflection.register(access.findClassByName("sun.rmi.server.UnicastRef2").getConstructors()); to the JMXClientFeature reflection config? It isn't related to your changes here, but is fixes a bug I caught while testing these changes.

You can also remove RuntimeReflection.register(access.findClassByName("sun.rmi.server.UnicastRef").getMethods()); I don't think its actually needed

@fniephaus
Copy link
Member

Thanks for the quick review!

Can you please add RuntimeReflection.register(access.findClassByName("sun.rmi.server.UnicastRef2").getConstructors()); to the JMXClientFeature reflection config? It isn't related to your changes here, but is fixes a bug I caught while testing these changes.

Any way we can add a test for this?

@roberttoyonaga
Copy link
Collaborator

Any way we can add a test for this?

Hi Fabio, yes I can create a follow up PR with the test

@fniephaus
Copy link
Member

Hi Fabio, yes I can create a follow up PR with the test

Sure, that'd work but then, I'd prefer if you also do the UnicastRef changes in that PR so that we have fix and test in one PR.

@roberttoyonaga
Copy link
Collaborator

I'd prefer if you also do the UnicastRef changes in that PR so that we have fix and test in one PR.

ok yes that makes sense

It is not needed as it only provides an implementation for `maxObjectInspectionAge()`, which is substituted in SVM.
@graalvmbot graalvmbot force-pushed the fniephaus/GR-45044/drop-rmi branch from f23c6e4 to d054444 Compare March 22, 2023 15:50
@graalvmbot graalvmbot merged commit 9d252f5 into master Mar 23, 2023
@graalvmbot graalvmbot deleted the fniephaus/GR-45044/drop-rmi branch March 23, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants