[GR-36033] Properly calculate root module sets when not running on module path #5813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
graalvmbot
force-pushed
the
ivan-ristovic/GR-36033
branch
from
e338a5b to
54180fa
Compare
graalvmbot
force-pushed
the
ivan-ristovic/GR-36033
branch
from
06a7e45 to
1c7dde9
Compare
graalvmbot
force-pushed
the
ivan-ristovic/GR-36033
branch
3 times, most recently
from
cecbd56 to
d84090b
Compare
graalvmbot
force-pushed
the
ivan-ristovic/GR-36033
branch
4 times, most recently
from
f086f9d to
1e9051a
Compare
graalvmbot
force-pushed
the
ivan-ristovic/GR-36033
branch
from
6c6b82e to
1e9051a
Compare
graalvmbot
force-pushed
the
ivan-ristovic/GR-36033
branch
from
1e9051a to
5d33c2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module system constructs a module graph starting from the root module set. Currently, the Native Image builder includes only reachable modules in the image (and therefore in the root module set).
As described in the Module System JEP (261), when running on the classpath, the expected behavior is to include
java.modules in the root module set that export at least one package unconditionally. There are JCK tests that run on classpath and assert over modules that the analysis did not mark as reachable, e.g.:api/modulegraph/ModuleGraphTest.html(tracked by GR-36033) - Performs boot module layer assertions based on the XML specification. The test itself does not use RMI but the XML specification expects thatjava.rmiis present in the boot module layer.This PR implements the classpath default root module set specification and, as a consequence, makes these JCK tests pass on Native Image.