Added support to register/access resource with trailing slash. #3597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hello jovanstevanovic, thanks for contributing a PR to our project! We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address jovan -(dot)- stevanovic1 -(at)- outlook -(dot)- com. You can sign it at that link. If you think you've already signed it, please comment below and we'll check. |
vjovanov
reviewed
Jul 16, 2021
substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/ResourcesFeature.java
Outdated
Show resolved
Hide resolved
zakkak
reviewed
Jul 16, 2021
substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jdk/Resources.java
Outdated
Show resolved
Hide resolved
Collaborator
|
jovanstevanovic has signed the Oracle Contributor Agreement (based on email address jovan -(dot)- stevanovic1 -(at)- outlook -(dot)- com) so can contribute to this repository. |
vjovanov
approved these changes
Sep 27, 2021
jovanstevanovic
deleted the
jovanstevanovic/improved_resource_registration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In most cases, directories as a resource are registered with a trailing slash, and currently, it's not supported. Similarly, when the directories as a resource are accessed with a trailing slash, they won't be found because of the same reason. This PR tries to fix both problems.
Linked issue
micronaut-projects/micronaut-core#5765