Skip to content

Implement basic module substitutions #3397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 336 commits into from
Closed

Implement basic module substitutions #3397

wants to merge 336 commits into from

Conversation

@ivan-ristovic
Copy link
Contributor

@ivan-ristovic ivan-ristovic commented May 10, 2021

This PR implements basic methods of the Module class.

Change list:

  • Removed substitutions for methods such as canRead(), canUse() etc. because the JDK implementation can be reused
  • Removed @Delete annotation from ReflectionData, because it is used by JDK
  • Redefine the value of the ReflectionData.uses field, otherwise it will contain classes that were not nececarily discovered by analysis
  • Added an alias for java.lang.WeakHashMap, in order to redefine the ReflectionData.uses field

@ivan-ristovic ivan-ristovic mentioned this pull request May 10, 2021
Merged
dougxc and others added 18 commits May 10, 2021 12:08
@dougxc
remove accidental usage of non-public JDK API
9b7b0ae
@dougxc
append devkit packages instead of overriding all other packages
52709cf
@dougxc
suppressed deprecation warnings
a0b6829
@dougxc
update overlay
354d435
@dougxc
add a guard to every jsonnet defined builder to avoid running it if o…
6b7cda1 
…nly *.md files are edited by a PR (GR-30750)
@dougxc
avoid issues with javac —release option
b779a68 
- refer to proprietary java.awt.peer.ComponentPeer symbolically
- do not subclass FinalReference
@dougxc
pass --add-exports in args file on Windows (GR-31100)
3f9b69f
@dougxc
remove deprecated instantiation of wrapper classes for primitives (#3073
07e742f 
)
@dougxc
adapt to VM symbol additions and changes
c303979
@dougxc
added missing requireConcealed attributes
0a6df89
@dougxc
remove hard coded assumptions about mx build location and layout
7f77be7
@dougxc
reduce gate noise for DynamicConstantTest
c948d66
@dougxc
dump phases as a tree for -Dgraal.ShowConfiguration=verbose
dc66d1d
@steve-s
Add regression test for race condition in DSL generated code
ea7b5ab
@steve-s
Fix DSL cached data race with memory fence in executeAndSpecialize
1745ed8
@steve-s
CachedDataRaceTest: fewer repetitions & upper bound for the threads c…
0e89a68 
…ount
@steve-s
CachedDataRaceTest: gracefully shutdown the executor service
7829f37
@javeleon
remove duplicate interface
a26d874
ansalond and others added 13 commits May 17, 2021 22:36
@ansalond
Merge remote-tracking branch 'origin/master' into da/static_object_3
145ccef
@ansalond
Use unsigned comparison for bounds check.
e81575d
Mark array types of elemental-type-supertypes as reachable
f422d95
@iamstolis
[GR-31370] Wasm: Memory allocation failure should not be an internal …
e13e9a5 
…error.

PullRequest: graal/8940
@ansalond
[GR-24401] Generalize the object model of Espresso.
44a1ff6 
PullRequest: graal/8738
@zapster
[GR-30564] SVM: do not fail if the phases to be removed are not there…
f910811 
… in the first place.

PullRequest: graal/8945
@davleopo
ivs: add duplication method
ca787d3
@javeleon
Merge branch 'master' into ag/GR-29730-hotswap-api
7baeb52
Reorder phases before the compilation.
c6ee7b4
@javeleon
update comment to clarify class renaming in relation to class loader …
7270e21 
…constraints
[GR-31245] Remove unnecessary code in BytecodeParser.
f88cd1e 
PullRequest: graal/8938
@pejovica
Adjust com.oracle.truffle.nfi.native project to mx changes
5c6d29b
@christianhaeubl
[GR-31041] Support PhantomReference.refersTo0.
889ca5c 
PullRequest: graal/8946
@olpaw olpaw self-requested a review May 18, 2021 13:03
davleopo and others added 14 commits May 18, 2021 14:53
@davleopo
[GR-31349] IVs: add duplication method.
e101aaa 
PullRequest: graal/8948
@javeleon
[GR-29730] New Espresso HotSwap API.
51c2127 
PullRequest: graal/8695
@pejovica
[GR-31354] Improve detection of JDK dependent native projects.
48d7e7f 
PullRequest: graal/8960
@loicottet
[GR-31075] Add bench-suite default datapoint for benchmarks.
eacbea8 
PullRequest: graal/8898
@tzezula
[GR-31285] Workaround missing JFR events using trace compilation deta…
ba037b0 
…ils in the polybench.

PullRequest: graal/8936
@tzezula
[GR-31309] Cannot invoke default methods of interfaces implemented in…
29d856e 
… polyglot languages without explicit --add-reads.

PullRequest: graal/8949
[GR-31165] Mark array types of elemental-type-supertypes as reachable.
a7fcb95 
PullRequest: graal/8955
@javeleon
fix npe
0601f96
@javeleon
[GR-31464] Fix NPE in EspressoContext#lookup.
8a2b6a5 
PullRequest: graal/8969
Initial Module substitution rework
fa32be9
Minor style changes
5527b98
Add feature to synthesize the boot module layer
4caa1df
Merge old Target_java_lang_Module with new version
8e1dd0c
Style fix
0683d4f
@ivan-ristovic
Copy link
Contributor Author

ivan-ristovic commented Jun 2, 2021

I moved this PR to #3445 for better clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olpaw olpaw Awaiting requested review from olpaw

Assignees

No one assigned

Labels

oca-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.