Skip to content

[GR-69986] Fix standalone points-to unittests and add them to gate. #12233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[GR-69986] Fix standalone points-to unittests and add them to gate. #12233

wants to merge 4 commits into from
+62 −99

Conversation

graalvmbot
Copy link
Collaborator

Included in this PR:

  • Open packages for standalone points-to unit tests.
  • Update points-to analyzer.
  • Clean-up tests.
  • Add standalone pointsto unittests to gate.

The tests can be run from the graal top directory using either the vm suite:

$ cd ~/projects/graal/
$ mx --primary-suite vm --env ce build
$ mx --primary-suite vm --env ce unittest --record-results --print-failed failed.txt --use-graalvm com.oracle.graal.pointsto.standalone.test

or the substratevm suite:

$ cd ~/projects/graal/
$ mx --primary-suite substratevm build
$ mx --primary-suite substratevm unittest --record-results --print-failed failed.txt --use-graalvm com.oracle.graal.pointsto.standalone.test

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 25, 2025
@cstancu cstancu linked an issue Sep 25, 2025 that may be closed by this pull request
[GR-69986] mx unittestcan't reliably execute seleted tests #12213
Open
@cstancu cstancu requested a review from dougxc September 25, 2025 09:47
dougxc
dougxc previously approved these changes Sep 25, 2025
View reviewed changes
JohnTortugo
JohnTortugo approved these changes Sep 26, 2025
View reviewed changes
substratevm/mx.substratevm/mx_substratevm.py Outdated
with Task('standalone pointsto unittests', tasks, tags=[GraalTags.standalone_pointsto_unittests]) as t:
if t:
if '--static' in args.extra_image_builder_arguments:
mx.warn('Skiping standalone pointsto unittests.')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: Skipping.

@graalvmbot graalvmbot force-pushed the cs/GR-69986-points-to-unittest branch from b36a3c0 to a10ff75 Compare September 29, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougxc dougxc dougxc left review comments

+1 more reviewer

@JohnTortugo JohnTortugo JohnTortugo approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@cstancu cstancu

Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GR-69986] mx unittestcan't reliably execute seleted tests
4 participants
@graalvmbot @JohnTortugo @dougxc @cstancu