[GR-67973] Fix graph scheduling segfaults for CEntryPoints. #11833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
@CEntryPointmethods that are annotated with@Uninterruptible, the compiler can inline the prologue and the target method into the same compilation unit. This causes problems that are similar to GR-67902 because values (such as Java object constants) can float above the point where we set the heap base.The functional changes in this PR are fairly small (explicitly disable inlining in some scenarios, see JavaDoc on
CEntryPointCallStubMethod). However, I also added more documentation and did a few small cleanups.